fix: remove casts of structs to record batch #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blajda
changed the title
|
Hi all, I reported the linked issue. I pulled down the changes locally and can confirm delete's are now working for me as expected! |
ion-elgreco
reviewed
Jan 6, 2024
| let col = batch.column_by_name(f.name()).unwrap(); | ||
|
|
||
| .map(|field| { | ||
| let col = struct_array.column_by_name(field.name()).unwrap(); | ||
| if let (DataType::Struct(_), DataType::Struct(child_fields)) = |
There was a problem hiding this comment.
There is one branch missing I guess and that's if the data type is List(Struct), so perhaps we need to add, such kind of check:
else if (DataType::List(_), DataType::List(to_inner_field)) {
match to_inner_field.data_type() {
Struct(child_fields) => .... do struct casting here,
_ => ... continue normal flow
}
}sorry for awful formatting (doing this on a phone)
There was a problem hiding this comment.
I think this should be a follow up PR. Primary scope for this is to remove the panic / unsoundness that occurred with null-able structs. If a List<Struct> is provided and LHS does not match RHS then a proper error value is returned by cast_with_options.
There was a problem hiding this comment.
Alright let's have this in a separate PR :)
ion-elgreco
requested changes
Jan 6, 2024
ion-elgreco
approved these changes
Jan 6, 2024
r3stl355
pushed a commit
to r3stl355/delta-rs
that referenced
this pull request
Jan 10, 2024
# Description Fixes an issue where the writer attempts to convert a Arrow `Struct` into a `RecordBatch`. This cannot be done since it will drop the validity array and would prevents structs with a value of `null` from being stored correctly. This PR also extends the predicate representation for struct field access, list index access, and list range access. # Related Issue(s) - closes delta-io#2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the writer attempts to convert a Arrow
Structinto aRecordBatch. This cannot be done since it will drop the validity array and would prevents structs with a value ofnullfrom being stored correctly.This PR also extends the predicate representation for struct field access, list index access, and list range access.
Related Issue(s)