fix: add data_type and nullable to StructField hash (#2045) #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there seems to be an error unrelated to this PR |
|
@sonhmai not so sure about that, these failures weren't there before. Maybe some interaction somewhere else in the code? |
yep. will definitely look into details. |
|
@ion-elgreco fix pushed with local tests passed. can you plz let workflow run? Thanks. |
|
@rtyler @ion-elgreco all checks passed! |
ion-elgreco
approved these changes
Feb 24, 2024
emcake
reviewed
Feb 25, 2024
| @@ -641,6 +643,7 @@ mod tests { | |||
| use super::*; | |||
| use serde_json; | |||
| use serde_json::json; | |||
| use std::hash::DefaultHasher; | |||
There was a problem hiding this comment.
incase anyone else runs into this - this raises the MSRV of running the tests to 1.76.
There was a problem hiding this comment.
thanks for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct hashing of StructField and add tests.
data_typeor differentnullableare considered to hash equivalently.name,data_typeandnullabilityshould match for a field to be considered equivalent.Related Issue(s)
closes #2045