fix: return error when checkpoints and metadata get out of sync #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a table is corrupted and `_last_checkpoint` file points to a version that has been deleted, `list_log_files_with_checkpoint` function panics. With this change `list_log_files_with_checkpoint` function returns an error allowing callers react to such issues. - delta-io#2290
|
Looks like mac os build has failed but I doubt it is related to my changes: I am running on mac and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a table is corrupted and
_last_checkpointfile points to aversion that has been deleted,
list_log_files_with_checkpointfunction panics. With this change
list_log_files_with_checkpointfunction returns an error allowing callers react to such issues.
Related Issue(s)
deltalake_core::kernel::snapshot::log_segment::list_log_files_with_checkpoint::{{closure}}#2290