Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust, python): fixed differences in storage options between log and object stores #2500

Merged
merged 4 commits into from
May 15, 2024

Conversation

mightyshazam
Copy link
Contributor

The object store changes the keys used for creating the s3 options, while the log store does not. The difference between the two, and their usage together was causing some weird fallback behavior in the AWS SDK that invoked the IMDS service despite explicitly disabling it in multiple places. This fix handles the potentially different casing along with passing the options unmolested. It should stop any future, unwanted, IMDS behavior

Description

The description of the main changes of your pull request

Related Issue(s)

Documentation

…nd object stores causing divergent dynamodb behavior
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label May 11, 2024
@rtyler rtyler enabled auto-merge (rebase) May 13, 2024 18:35
@ion-elgreco ion-elgreco disabled auto-merge May 15, 2024 05:53
@ion-elgreco ion-elgreco enabled auto-merge (squash) May 15, 2024 05:53
@ion-elgreco ion-elgreco merged commit f11f9bb into delta-io:main May 15, 2024
20 checks passed
@mightyshazam mightyshazam deleted the fix-aws-region-imds branch June 7, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 object store always returns IMDS warnings
3 participants