fix: enable field_with_name to support nested fields with '.' delimiter #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilcoxson-rel
requested review from
wjones127,
roeap and
rtyler
as code owners
rtyler
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
field_with_nameon schema type does not handle nested field names. This comes up when setting the data skipping stats column property. For example when I set this value toparent.child, the stats handling code in table load/scan throws an error that it cannot find a field namedparent.child.Area where we would see the error:
delta-rs/crates/core/src/kernel/snapshot/mod.rs
Line 296 in fae1406