Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: msrv in workspace #2524

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: msrv in workspace #2524

merged 1 commit into from
May 18, 2024

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented May 18, 2024

Description

Our min required rust version does not match the features we are using. Specifically, we are using impl Trait as a return type in a trait, which is only available since 1.75.

pub(crate) trait DataFusionFileMixins {
/// Iterate over all files in the log matching a predicate
fn files_matching_predicate(&self, filters: &[Expr]) -> DeltaResult<impl Iterator<Item = Add>>;
}

Related Issue(s)

This was raised in a discussion #2514.

Documentation

@roeap roeap merged commit 1d2bf64 into delta-io:main May 18, 2024
20 checks passed
@roeap roeap deleted the fix/msrv branch May 18, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants