Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom dynamodb endpoint configuration #2575

Merged
merged 20 commits into from
Jun 7, 2024

Conversation

hnaoto
Copy link
Contributor

@hnaoto hnaoto commented Jun 6, 2024

Description

Add custom dynamodb endpoint configuration
Users can specify dynamodb endpoint in the map or set the environment variable AWS_ENDPOINT_URL_DYNAMODB to override dynamodb client endpoint.

Related Issue(s)

2498

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@hnaoto hnaoto changed the title feat: Add custom dynamodb endpoint configuration feat: add custom dynamodb endpoint configuration Jun 6, 2024
@ion-elgreco
Copy link
Collaborator

@hnaoto thanks!

@ion-elgreco ion-elgreco merged commit 0a44a0d into delta-io:main Jun 7, 2024
20 checks passed
@ion-elgreco
Copy link
Collaborator

@hnaoto can you also update the docs on s3 and dynamodb later on with this new change?

@hnaoto
Copy link
Contributor Author

hnaoto commented Jun 8, 2024

Thanks for reviewing the PR @ion-elgreco !

Yes, would you mind me asking where I can find the docs? Is it this one https://delta-io.github.io/delta-rs/usage/writing/writing-to-s3-with-locking-provider/ (for python)? The rust one is automatically generated. Is there another user guide for Rust?

@ion-elgreco
Copy link
Collaborator

@hnaoto that's the one yeah, you should see the related markdown file somewhere in the repo.

There is no specific guide for Rust, but this one is written generic enough. It's just that the example is often in Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment