Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stale code for conditional import of Literal #2676

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

fpgmaas
Copy link
Contributor

@fpgmaas fpgmaas commented Jul 16, 2024

Description

The codebase contains the following code twice:

if sys.version_info >= (3, 8):
    from typing import Literal
else:
    from typing_extensions import Literal

I believe this can be removed, since pyproject.toml specifies that the minimum Python version for the project is 3.8:

requires-python = ">=3.8"

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/python Issues for the Python package label Jul 16, 2024
@fpgmaas
Copy link
Contributor Author

fpgmaas commented Jul 16, 2024

CI/CD is failing due to this issue. Merging this PR will solve it for now.

@ion-elgreco ion-elgreco enabled auto-merge (squash) July 21, 2024 20:20
@ion-elgreco ion-elgreco merged commit 9bb17a4 into delta-io:main Jul 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants