fix(rust,python): checkpoint with column nullable false #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockbeard
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
|
Thanks for the pull request! I was trying out this patch and couldn't get the tests to fail, how were you running/validating the python tests for the Rust changes? |
you can trigger this new test on main tests/test_checkpoint.py::test_checkpoint_with_nullable_false |
ion-elgreco
previously approved these changes
Jul 17, 2024
ion-elgreco
changed the title
ion-elgreco
approved these changes
Jul 18, 2024
rtyler
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when creating min , max schema make sure the nullable is true
Related Issue(s)
closes #2675
Documentation