feat: use logical plan in delete, delta planner refactoring #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
feat/logical_delete
branch
from
7a7a065
to
eab62f5
Compare
hntd187
previously approved these changes
Aug 4, 2024
ion-elgreco
commented
Aug 4, 2024
ion-elgreco
force-pushed
the
feat/logical_delete
branch
from
e1dec1d
to
a5bd9ac
Compare
rtyler
force-pushed
the
feat/logical_delete
branch
from
c1889d2
to
a6aeeca
Compare
rtyler
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes delete to use logical plans from the get-go. I had to introduce
with_filesonDeltaTableProviderin case you want to constraint the scope of files to be read.Additionally abstracts a DeltaPlanner struct, which was left as TODO, I used this to create a delete MetricObservation node
This one needs to be merged first: #2722