feat(python, rust): add ColumnProperties And rework in python WriterProperties #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockbeard
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
ion-elgreco
force-pushed
the
writerPropertyRework
branch
from
4efde05
to
e1eb87e
Compare
|
Great work! I like what you did with the WriterProperties Derive, makes me think I should take a look through the pyo3 side if we can use more of these useful features :) Could you force push your branch to make a better commit (you can use the PR name), since we are rebasing on top of main |
sherlockbeard
force-pushed
the
writerPropertyRework
branch
from
e1eb87e
to
4dd6815
Compare
|
@ion-elgreco commit message changed 🕺 |
ion-elgreco
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The description of the main changes of your pull request
addded ColumnProperties & BloomFilterProperties in WriterProperties
Related Issue(s)
closes #2785
Documentation