fix: use correct aws_endpoint key #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
=======================================
Coverage 72.39% 72.40%
=======================================
Files 128 128
Lines 41010 41017 +7
Branches 41010 41017 +7
=======================================
+ Hits 29690 29697 +7
+ Misses 9423 9422 -1
- Partials 1897 1898 +1 ☔ View full report in Codecov by Sentry. |
is_aws() should be executing after with_env_s3 which downcases the parameters, but this is a bit more defensive in checking the presence of both aws_endpoint and the uppercase constant Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
rtyler
force-pushed
the
fix/is_aws_check
branch
from
c7d1a9a to
20247e9
Compare
rtyler
approved these changes
Dec 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the is_aws check by using the correct aws_endpoint key. It's always the
aws_endpointlowercase after going throughwith_env_s3