Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scalar extraction view types #3095

Merged

Conversation

ion-elgreco
Copy link
Collaborator

Description

Fixes the polars test failures: https://github.com/pola-rs/polars/actions/runs/12580193685/job/35061681377#step:11:230

I'll do a bugfix release after merge

Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
@ion-elgreco ion-elgreco enabled auto-merge January 2, 2025 11:02
@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (21efab3) to head (93e1a12).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/kernel/scalars.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
+ Coverage   72.54%   72.55%   +0.01%     
==========================================
  Files         128      128              
  Lines       41193    41201       +8     
  Branches    41193    41201       +8     
==========================================
+ Hits        29882    29894      +12     
- Misses       9401     9404       +3     
+ Partials     1910     1903       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Jan 2, 2025
Merged via the queue into delta-io:main with commit 9e35c06 Jan 2, 2025
24 checks passed
@ion-elgreco ion-elgreco deleted the fix/scalar_extraction_view_types branch January 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants