Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #3138

Merged
merged 2 commits into from
Jan 17, 2025
Merged

chore: fix typos #3138

merged 2 commits into from
Jan 17, 2025

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Jan 16, 2025

Description

Thanks to my recently installed spellchecker, I was made aware of some types scattered across the codebase.

Signed-off-by: Robert Pack <robstar.pack@gmail.com>
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jan 16, 2025
@ion-elgreco
Copy link
Collaborator

@roeap I think the latest pyarrow version 19 broke some things in our CI. Maybe we should pin it for now?

@roeap
Copy link
Collaborator Author

roeap commented Jan 16, 2025

@ion-elgreco - I'll let you be the judge on that since I have no good handle on how big the effort would be to just fix it?

@ion-elgreco
Copy link
Collaborator

@ion-elgreco - I'll let you be the judge on that since I have no good handle on how big the effort would be to just fix it?

Let's pin pyarrow in the CI for now to < 19. It likely is an issue in arrow I think because it's complained about malformed things even though with lower pyarrow version it can read parquet fine

Signed-off-by: Robert Pack <robstar.pack@gmail.com>
@roeap roeap requested a review from fvaleye as a code owner January 17, 2025 08:11
@github-actions github-actions bot added the binding/python Issues for the Python package label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (af3102e) to head (92f5875).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/azure/src/lib.rs 0.00% 3 Missing ⚠️
crates/catalog-unity/src/lib.rs 0.00% 3 Missing ⚠️
crates/core/src/storage/mod.rs 25.00% 0 Missing and 3 partials ⚠️
crates/gcp/src/lib.rs 0.00% 3 Missing ⚠️
...ore/src/operations/transaction/conflict_checker.rs 33.33% 2 Missing ⚠️
python/src/error.rs 0.00% 2 Missing ⚠️
crates/aws/src/errors.rs 0.00% 1 Missing ⚠️
crates/core/src/operations/cast/merge_schema.rs 66.66% 0 Missing and 1 partial ⚠️
crates/core/src/operations/constraints.rs 0.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/merge/mod.rs 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
+ Coverage   72.07%   72.08%   +0.01%     
==========================================
  Files         134      134              
  Lines       43362    43360       -2     
  Branches    43362    43360       -2     
==========================================
+ Hits        31252    31258       +6     
+ Misses      10087    10084       -3     
+ Partials     2023     2018       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roeap roeap enabled auto-merge January 17, 2025 08:23
@roeap roeap added this pull request to the merge queue Jan 17, 2025
Merged via the queue into delta-io:main with commit 7d29885 Jan 17, 2025
26 checks passed
@roeap roeap deleted the chore/typos branch January 17, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants