Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache cargo builds #359

Merged
merged 1 commit into from
Aug 9, 2021
Merged

cache cargo builds #359

merged 1 commit into from
Aug 9, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Aug 8, 2021

Description

Cache cargo builds to speed up CI

@houqp houqp requested review from rtyler, mosyp and fvaleye August 8, 2021 04:39
@houqp
Copy link
Member Author

houqp commented Aug 8, 2021

build time reduced from 6m to 2m, looks pretty effective.

@houqp houqp enabled auto-merge (squash) August 8, 2021 05:17
@houqp houqp disabled auto-merge August 8, 2021 05:18
@houqp houqp enabled auto-merge (squash) August 8, 2021 05:18
mosyp
mosyp approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@mosyp mosyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I love caches 🔥

@houqp houqp merged commit 5926052 into main Aug 9, 2021
@houqp houqp deleted the qp_cache branch August 9, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosyp mosyp mosyp approved these changes

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houqp @mosyp