Gcs writer bugs #412
Merged
Gcs writer bugs #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 24, 2021 14:37
…subsequently delete it" This reverts commit 888fe10.
|
Thanks for your PR @blogle Do you think it's worth adding a unit test for delta-rs/rust/src/storage/gcs/util.rs Line 33 in 83c987a |
rtyler
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After putting together some code to actually write into gcs, I had encountered a few issues.
The storage backend rename method was attempting to cleanup the src file, but it turns out this is unnecessary`EDIT: nope that delete in rename is needed