Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage of the Python tests #467

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

fvaleye
Copy link
Collaborator

@fvaleye fvaleye commented Oct 18, 2021

Description

  • Add the init pytest options in the pyproject.toml
  • Fix the coverage report of the Python tests

@fvaleye fvaleye added the binding/python Issues for the Python package label Oct 18, 2021
@fvaleye fvaleye enabled auto-merge (squash) October 18, 2021 05:30
@fvaleye fvaleye disabled auto-merge October 18, 2021 06:05
@houqp
Copy link
Member

houqp commented Oct 18, 2021

the python test failure looks quite strange, are you able to reproduce locally?

@fvaleye
Copy link
Collaborator Author

fvaleye commented Oct 18, 2021

the python test failure looks quite strange, are you able to reproduce locally?

Yes, It runs well when I am using maturin develop and pytest-cov displays the good coverage stats 😄. I will fix the CI to use a virtualenv in a development mode before running the tests

@fvaleye fvaleye force-pushed the python/fix-coverage branch from a8dced0 to 473a49f Compare October 18, 2021 08:16
@fvaleye
Copy link
Collaborator Author

fvaleye commented Oct 18, 2021

The pytest-cov plugin is now working!

---------- coverage: platform linux, python 3.6.12-final-0 -----------
Name                        Stmts   Miss  Cover
-----------------------------------------------
deltalake/__init__.py           4      0   100%
deltalake/data_catalog.py       3      0   100%
deltalake/schema.py           165     29    82%
deltalake/table.py            101     18    82%
-----------------------------------------------
TOTAL                         273     47    83%

@fvaleye fvaleye enabled auto-merge (squash) October 18, 2021 09:15
@fvaleye fvaleye merged commit ea470ea into delta-io:main Oct 18, 2021
@houqp
Copy link
Member

houqp commented Oct 18, 2021

time to hook it up with codecov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants