Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse partition values before handing to PyArrow #565

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Parse partition values before handing to PyArrow #565

merged 4 commits into from
Mar 10, 2022

Conversation

wjones127
Copy link
Collaborator

Description

We were providing all partition values as strings, by PyArrow expects them to be parsed to the correct type.

Related Issue(s)

Documentation

@wjones127
Parse partition values before handing to PyArrow
fd7e0a9 
We were providing all partition values as strings, by PyArrow expects
them to be parsed to the correct type.
wjones127
wjones127 commented Feb 26, 2022
View reviewed changes
python/Cargo.toml Outdated Show resolved Hide resolved
@wjones127 wjones127 marked this pull request as ready for review February 26, 2022 17:15
houqp
houqp previously approved these changes Feb 28, 2022
View reviewed changes
@houqp houqp requested a review from fvaleye February 28, 2022 05:56
@houqp
Copy link
Member

houqp commented Feb 28, 2022

The build error is caused by rustc update and not related to this PR. @fvaleye you want to take a final look at this change?

fvaleye
fvaleye previously approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@fvaleye fvaleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @wjones127

@wjones127 wjones127 dismissed stale reviews from fvaleye and houqp via cae052c February 28, 2022 16:50
@wjones127 wjones127 force-pushed the bugfix/date-partitions branch from d8bf257 to cae052c Compare February 28, 2022 16:50
@wjones127
Copy link
Collaborator Author

Force pushed with no new changes to rerun CI.

fvaleye
fvaleye reviewed Mar 8, 2022
View reviewed changes
python/src/lib.rs Outdated Show resolved Hide resolved
@wjones127 wjones127 requested a review from fvaleye March 8, 2022 20:26
houqp
houqp approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave the merge button to @fvaleye :D

fvaleye
fvaleye approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@fvaleye fvaleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @wjones127 👍

@fvaleye fvaleye merged commit d54e952 into delta-io:main Mar 10, 2022
@wjones127 wjones127 deleted the bugfix/date-partitions branch March 10, 2022 18:29
@Tom-Newton Tom-Newton mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvaleye fvaleye fvaleye approved these changes

@houqp houqp houqp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read delta table partitioned by a date typed column
3 participants
@wjones127 @houqp @fvaleye