Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to root for empty path in azure store #603

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented May 10, 2022

Description

Defaults to a root path if there is no path segment in an azure storage path.

i..e this does work right now adls2://account/container/, while this does not work adls2://devargusadlsv2/simple. THis PR makes the second option also work.

Related Issue(s)

closes #602

Documentation

@roeap roeap requested a review from thovoll May 12, 2022 04:46
@thovoll
Copy link
Contributor

thovoll commented May 12, 2022

Thanks @roeap! Are the tests passing from your local machine?

@roeap
Copy link
Collaborator Author

roeap commented May 12, 2022

yes, they are :) However, I am hoping to migrate the last function in the azrue sdk to finally activate tests in cicd...

Copy link
Contributor

@thovoll thovoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thovoll thovoll merged commit 996c48c into delta-io:main May 12, 2022
@roeap roeap deleted the fix-azure branch May 12, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADLS2 backend fails to load table from container root
2 participants