Handle pandas timestamps #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema to microsecond timestamps
hayesgb
requested review from
wjones127,
fvaleye,
rtyler,
roeap and
houqp
as code owners
wjones127
requested changes
Nov 26, 2022
python/deltalake/writer.py
Outdated
Comment on lines
140
to
143
| _data = pa.Table.from_pandas(data) | ||
| _schema = _data.schema | ||
| schema_out = [] | ||
| for _field in _schema: |
There was a problem hiding this comment.
Would you be willing to pull this out into a helper function (_delta_arrow_schema_from_pandas)?
There was a problem hiding this comment.
Really like this idea. Factored this out into a helper function, but I'd prefer it to be public rather than private. Would like to leverage this helper function elsewhere. Thoughts?
There was a problem hiding this comment.
Sure, but if you make it public, then I'd suggest putting it in schema.py.
|
Not sure why |
|
@hayesgb you might need to add timestamp to https://github.com/delta-io/delta-rs/blob/main/python/stubs/pandas/__init__.pyi in order to fix the mypy error |
wjones127
requested changes
Nov 30, 2022
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
reviewed
Nov 30, 2022
wjones127
reviewed
Nov 30, 2022
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
reviewed
Dec 1, 2022
wjones127
reviewed
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #686 some pandas datatypes are not converted to a format that is compatible with delta lake. This handles the instance of timestamps, which are stored with
nsresolution in Pandas. Here, if is a schema is not provided, we specify converting the timestamps tousresolution.We also update
python/tests/test_writer.py::test_write_pandasto reflect this change.Related Issue(s)
#685