Add support for http proxy #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakankardb
reviewed
Jan 9, 2024
client/src/main/scala/io/delta/sharing/client/DeltaSharingFileSystem.scala
Outdated
Show resolved
Hide resolved
client/src/main/scala/io/delta/sharing/client/DeltaSharingFileSystem.scala
Show resolved
Hide resolved
chakankardb
reviewed
Jan 10, 2024
client/src/main/scala/io/delta/sharing/client/DeltaSharingFileSystem.scala
Outdated
Show resolved
Hide resolved
client/src/test/scala/io/delta/sharing/client/DeltaSharingFileSystemSuite.scala
Show resolved
Hide resolved
chakankardb
approved these changes
Jan 10, 2024
| assert(content.trim == "Hello, World!") | ||
|
|
||
| // Assert that the request is not passed through proxy. | ||
| assert(proxyServer.getCapturedRequests().isEmpty) |
moderakh
added a commit
to moderakh/delta-sharing
that referenced
this pull request
Jan 11, 2024
Adds support for Http Proxy when reading data from storage sample configuration: ``` spark.delta.sharing.network.proxyHost=1.2.3.4 spark.delta.sharing.network.proxyPort=3128 spark.delta.sharing.network.noProxyHosts=5.6.7.8,12.13.14.15 ```
moderakh
added a commit
that referenced
this pull request
Jan 11, 2024
linzhou-db
reviewed
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Http Proxy when reading data from storage
sample configuration: