Do not retry on ConnectionClosedException in branch 0.7 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakankardb
reviewed
Apr 9, 2024
| @@ -71,6 +71,9 @@ private[sharing] object RetryUtils extends Logging { | |||
| false | |||
| } | |||
| case _: java.net.SocketTimeoutException => true | |||
| // do not retry on ConnectionClosedException because it can be caused by invalid json returned | |||
| // from the delta sharing server. | |||
| case _: org.apache.http.ConnectionClosedException => false | |||
There was a problem hiding this comment.
Are there other cases where this should be retried (for example, some networking error) which may be more common?
There was a problem hiding this comment.
that's a good question, I'm not sure about the side effect of this change. As it's the client side change, we don't have good logs/stats on what are all the cases that trigger this error.
let me see if the current code works with a server side change, if not we can add more detailed check here but may still need it in some way.
charlenelyu-db
approved these changes
Apr 10, 2024
chakankardb
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not retry on ConnectionClosedException, because it can be caused by invalid json returned from the delta sharing server.
The same PR as #467