DTS-3385: migrate getTableVersion to use delta-kernel #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhou-db
reviewed
Jun 7, 2024
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/sharing/server/DeltaSharedTableProtocol.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/io/delta/sharing/server/DeltaSharedTableProtocol.scala
Outdated
Show resolved
Hide resolved
pranavsuku-db
changed the title
linzhou-db
approved these changes
Jun 10, 2024
server/src/main/scala/io/delta/kernelsharedtable/DeltaSharedTableKernel.scala
Show resolved
Hide resolved
linzhou-db
added a commit
to linzhou-db/delta-sharing
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTableVersion now uses the DeltaSharedTableKernel implementation. In this PR, delta-kernel is imported into OSS and DeltaSharedTableKernel and the original DeltaSharedTable inherit from a trait DeltaSharedTableProtocol. This protocol trait is what is returned by the table loader. The table loader will return a standalone DeltaSharedTable unless a parameter is specified to return the kernel implementation. This parameter is only turned on for getTableVersion.