DTS-3385: upgrade hadoop version #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhou-db
approved these changes
Jun 13, 2024
|
could you rerun the tests, and run them locally to double check? |
linzhou-db
reviewed
Jun 13, 2024
build.sbt
Outdated
| ExclusionRule("com.fasterxml.jackson.core"), | ||
| ExclusionRule("com.fasterxml.jackson.module"), | ||
| ExclusionRule("com.google.guava", "guava") | ||
| ), | ||
| "io.delta" %% "delta-standalone" % "0.5.0" excludeAll( | ||
| "io.delta" % "delta-kernel-api" % "3.2.0" excludeAll( |
There was a problem hiding this comment.
we don't need to include them twice?
build.sbt
Outdated
| ExclusionRule("com.fasterxml.jackson.module"), | ||
| ExclusionRule("com.google.guava", "guava") | ||
| ), | ||
| "io.delta" % "delta-storage" % "3.2.0" excludeAll( |
There was a problem hiding this comment.
and exclude this delta-storage library?
linzhou-db
approved these changes
Jun 14, 2024
linzhou-db
reviewed
Jun 14, 2024
build.sbt
Outdated
| ExclusionRule("com.fasterxml.jackson.core"), | ||
| ExclusionRule("com.fasterxml.jackson.module"), | ||
| ExclusionRule("com.google.guava", "guava") | ||
| ), | ||
| "io.delta" %% "delta-standalone" % "0.5.0" excludeAll( | ||
| "io.delta" % "delta-kernel-defaults" % "3.2.0" excludeAll( |
There was a problem hiding this comment.
This one is also a duplicate of the import below?
linzhou-db
approved these changes
Jun 14, 2024
| @@ -114,7 +115,7 @@ private[sharing] class RandomAccessHttpInputStream( | |||
| } | |||
|
|
|||
| private def createHttpRequest(start: Long): HttpRequestBase = { | |||
| val request = new HttpGet(uri) | |||
| val request = new HttpGet(URI.create(uri)) | |||
| @@ -40,6 +40,7 @@ | |||
| package io.delta.sharing.client | |||
|
|
|||
| import java.io.{EOFException, InputStream, IOException} | |||
| import java.net.URI | |||
| @@ -175,7 +176,12 @@ object AbfsFileSigner { | |||
| val getRelativePathMethod = classOf[AzureBlobFileSystemStore] | |||
| .getDeclaredMethod("getRelativePath", classOf[Path]) | |||
| getRelativePathMethod.setAccessible(true) | |||
| getRelativePathMethod.invoke(abfsStore, path).asInstanceOf[String] | |||
| var relativePath = getRelativePathMethod.invoke(abfsStore, path).asInstanceOf[String] | |||
| // remove duplicate separator character for azure relative path | |||
There was a problem hiding this comment.
And could you add this link in the comment as a reference of why we are doing this change: apache/hadoop@af98f32#diff-94925ffd3b21968d7e6b476f7e85f68f5ea326f186262017fad61a5a6a3815cbL1215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading hadoop version so it is compatible with delta-kernel