Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoresolve query format and support delta format RPC call #521

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

pranavsuku-db
Copy link
Collaborator

Added functions to set delta format headers. Added function to autoresolve query format. Added tests to verify correct format is being returned for different tables

python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@charlenelyu-db charlenelyu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one nit.

python/delta_sharing/rest_client.py Outdated Show resolved Hide resolved
@pranavsuku-db pranavsuku-db merged commit 292c392 into main Jul 2, 2024
6 of 8 checks passed
@pranavsuku-db pranavsuku-db deleted the pranav-suku-db-delta-format-autoresolve-query branch July 2, 2024 22:33
@@ -203,6 +208,24 @@ def __auth_basic(self, profile):
}
)

def set_delta_format_header(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should need update on this function later. because set_delta_format_header shouldn't set both delta/parquet in the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants