Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored server-side code #524

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

pranavsuku-db
Copy link
Collaborator

Moved Codec.scala, DeletionVectorDescriptor.scala, DeltaAction.scala into actions package in common. Moved CloudFileSigner.scala and DeltaAction.scala into common. This meant changing the imports in some other files.

This PR is purely a refactor and does not change any core logic. Does not require any additional testing since it is just a refactor

@pranavsuku-db pranavsuku-db changed the title refactored server-side code to cleaner packages refactored server-side code Jul 8, 2024
@pranavsuku-db
Copy link
Collaborator Author

The tests that are failing are connection timeouts and these tests have been flaky. Not related to to this work

@pranavsuku-db
Copy link
Collaborator Author

@linzhou-db I will probably address this in the JSON predicate hints PR where I add more files related to kernel, but do you have any ideas for what I should name the current package kernelsharedtable to? It is not consistent with the rest of the package names and feels a bit clunky. The issue is I cannot rename it to kernel.internal similar to how standalone.internal is named since that will conflict with the actual import from kernel.internal. One idea is we rename standalone.internal to sharing.standalone.internal and do the same for the new sharing.kernel.internal

@linzhou-db
Copy link
Collaborator

@linzhou-db I will probably address this in the JSON predicate hints PR where I add more files related to kernel, but do you have any ideas for what I should name the current package kernelsharedtable to? It is not consistent with the rest of the package names and feels a bit clunky. The issue is I cannot rename it to kernel.internal similar to how standalone.internal is named since that will conflict with the actual import from kernel.internal. One idea is we rename standalone.internal to sharing.standalone.internal and do the same for the new sharing.kernel.internal

sharing.standalone.internal and sharing.kernel.internal sounds good to me.

@pranavsuku-db pranavsuku-db merged commit d80db87 into main Jul 9, 2024
7 of 8 checks passed
@pranavsuku-db pranavsuku-db deleted the pranavsuku-db-refactor-server-code branch July 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants