Add python release script #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but I have not tested this on my local machine yet |
pranavsuku-db
approved these changes
Jul 23, 2024
| @@ -78,11 +79,10 @@ | |||
| "License :: OSI Approved :: Apache Software License", | |||
| "Operating System :: OS Independent", | |||
| "Topic :: Software Development :: Libraries :: Python Modules", | |||
| 'Programming Language :: Python :: 3.7', | |||
| 'Programming Language :: Python :: 3.8', | |||
| 'Programming Language :: Python :: 3.9', | |||
There was a problem hiding this comment.
Do we want to add 3.10 and 3.11 here?
python/setup.py
Outdated
| 'fsspec>=0.7.4', | ||
| 'requests', | ||
| 'aiohttp', | ||
| 'dataclasses;python_version<"3.7"', | ||
| 'dataclasses;python_version<"3.8"', | ||
| 'yarl>=1.6.0', | ||
| 'maturin', |
There was a problem hiding this comment.
we might be able to remove maturin here since it is only used to build delta_lernel_rust_sharing_wrapper but this is now being done in python_release.sh. Not totally sure though but if we can avoid having user install an extra package this might be a good thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add python release script