-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python release script #533
Add python release script #533
Conversation
lgtm but I have not tested this on my local machine yet |
@@ -78,11 +79,10 @@ | |||
"License :: OSI Approved :: Apache Software License", | |||
"Operating System :: OS Independent", | |||
"Topic :: Software Development :: Libraries :: Python Modules", | |||
'Programming Language :: Python :: 3.7', | |||
'Programming Language :: Python :: 3.8', | |||
'Programming Language :: Python :: 3.9', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add 3.10 and 3.11 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
python/setup.py
Outdated
'fsspec>=0.7.4', | ||
'requests', | ||
'aiohttp', | ||
'dataclasses;python_version<"3.7"', | ||
'dataclasses;python_version<"3.8"', | ||
'yarl>=1.6.0', | ||
'maturin', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might be able to remove maturin here since it is only used to build delta_lernel_rust_sharing_wrapper but this is now being done in python_release.sh. Not totally sure though but if we can avoid having user install an extra package this might be a good thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Add python release script