-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Empty Table Sharing with Kernel #535
Conversation
python/delta_sharing/reader.py
Outdated
@@ -146,11 +150,20 @@ def __to_pandas_kernel(self): | |||
# Close the file | |||
json_file.close() | |||
|
|||
if (num_files > DeltaSharingReader.FILE_NUMBER_WARNING_THRESH): | |||
print("Warning: Queries with a large number of files take a large ammount of time") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linzhou-db is there a better way to display the warning to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed offline, we don't need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's remove the warning.
python/delta_sharing/reader.py
Outdated
@@ -146,11 +150,20 @@ def __to_pandas_kernel(self): | |||
# Close the file | |||
json_file.close() | |||
|
|||
if (num_files > DeltaSharingReader.FILE_NUMBER_WARNING_THRESH): | |||
print("Warning: Queries with a large number of files take a large ammount of time") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed offline, we don't need this.
Support query of tables with no data (includes LIMIT 0 queries)