-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_table_as_pandas() allows user to determine whether or not to use kernel #536
Merged
pranavsuku-db
merged 9 commits into
main
from
pranavsuku-db-allow-user-select-kernel-mdoe
Aug 1, 2024
Merged
load_table_as_pandas() allows user to determine whether or not to use kernel #536
pranavsuku-db
merged 9 commits into
main
from
pranavsuku-db-allow-user-select-kernel-mdoe
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavsuku-db
commented
Jul 26, 2024
linzhou-db
reviewed
Jul 26, 2024
linzhou-db
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good!
Though let's test the production behavior before merging.
…uku-db-allow-user-select-kernel-mdoe
…uku-db-allow-user-select-kernel-mdoe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can lead to a 4x speedup of reading tables even without DV/CM support