Python OAuth client_credentials support #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
changed the title
linzhou-db
reviewed
Aug 14, 2024
python/delta_sharing/auth.py
Outdated
| # limitations under the License. | ||
| # | ||
|
|
||
| from abc import ABC, abstractmethod |
There was a problem hiding this comment.
This is a python pattern for making a class abstract in python by importing ABC from the python standard library, we will have access to abstractmethod annotation etc.
see https://docs.python.org/3/library/abc.html
| json = """ | ||
| { | ||
| "shareCredentialsVersion": 2, | ||
| "type": "persistent_oauth2.0", | ||
| "type": "oauth_client_credentials", |
There was a problem hiding this comment.
will changing this causing any break on existing traffic?
There was a problem hiding this comment.
no, this is already discussed with oracle who introduced this and they are fine with the change as there is no traffic persistent_oauth2.0
linzhou-db
approved these changes
Aug 14, 2024
moderakh
deleted the
moderakh/oauth-client-credentials-support-python-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OAuth implementation in the Python client does not reuse access tokens. Instead, it exchanges the client-id and client-secret for a new access token with every request. This behavior increases the load on the tokenEndpoint and introduces unnecessary latency in the request processing.
This PR updates the OAuth implementation to oauth reuse access tokens, aligning the Python client with the OAuth behavior of the Scala client, as detailed in this PR for the Scala client.
For additional context on the usage of auth_provider and its functionality, please refer to the description in the original PR for the Spark client.