Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Automatically generate partition filters for generated columns using the timestamp trunc function #1445

Closed
allisonport-db opened this issue Oct 18, 2022 · 4 comments
Closed

[Feature Request] Automatically generate partition filters for generated columns using the timestamp trunc function #1445

allisonport-db opened this issue Oct 18, 2022 · 4 comments
Assignees
@tfabritz
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@allisonport-db
Copy link
Collaborator

allisonport-db commented Oct 18, 2022 •
edited
Loading

See #1442

We can automatically generated partition filters when a partition column is generated by the TruncTimestamp function.

i.e. if t1 < t2 then date_trunc('QUARTER', t1) <= date_trunc('QUARTER', t2)
@allisonport-db allisonport-db added enhancement New feature or request good first issue Good for newcomers labels Oct 18, 2022
@allisonport-db allisonport-db mentioned this issue Oct 18, 2022
Open
@tfabritz
Copy link
Contributor

tfabritz commented Dec 7, 2022

I'd like to look into this

@tfabritz tfabritz mentioned this issue Dec 8, 2022
Closed
vkorukanti pushed a commit that referenced this issue Dec 29, 2022
@tfabritz @vkorukanti
Implement automated partition filters for TruncTimestamp (date_trunc)
f248ae9 
## Description

Adding automated partition filter creation for generated columns using TruncTimestamp (date_trunc)

Implements #1445

Test case was added

## Does this PR introduce _any_ user-facing changes?

Closes #1514

Signed-off-by: Allison Portis <allison.portis@databricks.com>
GitOrigin-RevId: 85003be24893458a4105d857c8c92fe31213a075
@chridac95
Copy link

@allisonport-db Is this still open? in that case, may I work on this?

@allisonport-db
Copy link
Collaborator Author

@chridac95 sorry this has been done. See #1442 for the parent issue; you can propose another function you think would be beneficial

@allisonport-db
Copy link
Collaborator Author

Closed by #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfabritz tfabritz

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tfabritz @chridac95 @allisonport-db