Improvements to DynamoDBLogStore.java feature #1 #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use Optional instead of null - comments - whitespace
- clarify absolutePath vs fileName for put/get entry in DB - add test - documentation
scottsand-db
changed the title
scottsand-db
changed the title
scottsand-db
commented
Mar 30, 2022
storage-dynamodb/src/test/java/io/delta/storage/MemoryLogStore.java
Outdated
Show resolved
Hide resolved
mrk-its
reviewed
Mar 30, 2022
storage-dynamodb/src/main/java/io/delta/storage/BaseExternalLogStore.java
Outdated
Show resolved
Hide resolved
scottsand-db
changed the base branch from
dynamodb_logstore_java_feature_branch
to
master
scottsand-db
changed the base branch from
master
to
dynamodb_logstore_java_feature_branch
…_java_feature_branch_fixes_1
scottsand-db
changed the title
…_branch' into dynamodb_logstore_java_feature_branch_fixes_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getwas using the file's json absolute path, butputwas using the file name. using the fileName is correct.