Add WHEN NOT MATCHED BY SOURCE support #1511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vkorukanti
approved these changes
Dec 7, 2022
| @@ -1068,6 +1068,12 @@ | |||
| ], | |||
| "sqlState" : "42000" | |||
| }, | |||
| "DELTA_NON_LAST_NOT_MATCHED_BY_SOURCE_CLAUSE_OMIT_CONDITION" : { | |||
There was a problem hiding this comment.
nit: Not sure if we can change the existing error messages, but this is same as the next one except the clause name which can be converted to a error msg parameter.
There was a problem hiding this comment.
These error codes are also defined in Spark: https://github.com/apache/spark/blob/master/core/src/main/resources/error/error-classes.json#L855
I think we would need to update them there first then in delta.
scottsand-db
pushed a commit
that referenced
this pull request
Jan 5, 2023
… BY SOURCE clause in merge commands. Support for the clause was introduced in #1511 using the Scala Delta Table API, this patch extends the Python API to support the new clause. See corresponding feature request: #1364 Adding python tests covering WHEN NOT MATCHED BY SOURCE to test_deltatable.py. The extended API for NOT MATCHED BY SOURCE mirrors existing clauses (MATCHED/NOT MATCHED). Usage: ``` dt.merge(source, "key = k") .whenNotMatchedBySourceDelete(condition="value > 0") .whenNotMatchedBySourceUpdate(set={"value": "value + 0"}) .execute() ``` Closes #1533 GitOrigin-RevId: 76c7aea481fdbbf47af36ef7251ed555749954ac
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
WHEN NOT MATCHED BY SOURCEto MergeIntoCommandThis PR adds support for
WHEN NOT MATCHED BY SOURCEclauses in merge into command using the Scala/Java Delta table API. Support forWHEN NOT MATCHED BY SOURCEusing SQL will be available with Spark 3.4 release and python support will follow up in a different PR.Changes:
NOT MATCHED BY SOURCEclause.NOT MATCHED BY SOURCEconditions and update actionsMATCHEDclause): generate update expressions to align with the expected target schemaNOT MATCHED BY SOURCEin MergeIntoCommand.How was this patch tested?
New test trait
MergeIntoNotMatchedBySourceSuiteis added and collects all tests covering this feature. It is mixed into the Merge Scala test class to run tests against the Delta API and will be mixed in the Merge base test class to also cover the Spark SQL API once Spark 3.4 is released.Test coverage:
Does this PR introduce any user-facing changes?
This change extends the existing Delta Merge API to allow specifying
WHEN NOT MATCHED BY SOURCEclauses and their corresponding optional condition and actions. The new API follows the existing APIs forMATCHEDandNOT MATCHEDclauses.Usage - Scala: