Add DeletionVectorDescriptor to represent DV metadata in DeltaLog
#1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of the feature: Support reading Delta tables with deletion vectors (more details of supporting DV table reads at delta-io#1485) This PR adds a new class called `DeletionVectorDescriptor` which is used to represent the deletion vector for a given file (`AddFile`) in `DeltaLog`. The format of the metadata is described in the [protocol](https://github.com/delta-io/delta/blob/master/PROTOCOL.md#deletion-vector-descriptor-schema). GitOrigin-RevId: 59979dea64d7c938d33b886eaebe0b30b2f8dd6c
3 tasks
larsk-db
reviewed
Dec 21, 2022
Comment on lines
134
to
140
| /** | ||
| * Produce a copy of this DV, with `pathOrInlineDv` replaced by a relative path based on `id` | ||
| * and `randomPrefix`. | ||
| */ | ||
| def copyWithNewRelativePath(id: UUID, randomPrefix: String): DeletionVectorDescriptor = { | ||
| this.copy(storageType = UUID_DV_MARKER, pathOrInlineDv = encodeUUID(id, randomPrefix)) | ||
| } |
There was a problem hiding this comment.
This should be a noop copy for inline DVs, since we shouldn't write them out to disk ever anyway.
There was a problem hiding this comment.
makes sense. Will update it.
| * Optionally, prepend a `prefix` to the name. | ||
| */ | ||
| def assembleDeletionVectorPath(targetParentPath: Path, id: UUID, prefix: String = ""): Path = { | ||
| val core = DELETION_VECTOR_FILE_NAME_CORE |
There was a problem hiding this comment.
Is it really worthwhile to assign a field to a (shorter) field? Why not just use the static field directly?
scottsand-db
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the feature: Support reading Delta tables with deletion vectors (more details at #1485)
It adds new class called
DeletionVectorDescriptorwhich is used to represent the deletion vector for a given file (AddFile) inDeltaLog. The format of the metadata is described in the protocol.How was this patch tested?
New test suite is added