Correct Delta protocol terminology "enabled" vs "supported" #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkorukanti Can you review this PR? |
larsk-db
reviewed
Aug 17, 2023
bart-samwel
reviewed
Aug 24, 2023
bart-samwel
reviewed
Oct 3, 2023
|
May need to update the changes from #2240, once it is merged |
xupefei
force-pushed
the
protocol-terminology
branch
from
33d20da
to
bd2524a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a terminology issue in Delta protocol, so the term
supportedis now used to describe a table feature name being listed in table protocol'sreaderFeaturesand/orwriterFeatures. The choice of this word is to emphasize that, in such a scenario, the Delta table may use the listed table features but is not forced to do so.For example, when
appendOnlyis listed in a table's protocol, the table may or may not be append-only, depending on the existence and value of table propertydelta.appendOnly. However, writers must recognize the table featureappendOnlyand know that the table property should be checked before writing this table.This PR did not touch the Row ID/Row Tracking sections, as it's handled by another PR: #1747.