Create initial structure for Delta Kernel development #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
reviewed
May 25, 2023
kernel/build.sbt
Outdated
| <url>https://github.com/delta-io/connectors</url> | ||
| <scm> | ||
| <url>git@github.com:delta-io/connectors.git</url> | ||
| <connection>scm:git:git@github.com:delta-io/connectors.git</connection> |
There was a problem hiding this comment.
since we dont know what the release structure is going to be like.. i am inclined to not make any assumptions here and forget about those later and accidentally release something wrong. I think we should remove this entire release setting stuff.
all we should ensure that we are generating a pure java artifact when locally published without _2.12 stuff at the end.
There was a problem hiding this comment.
Removed all the extra settings. Verified that publishM2 does as desired:
sbt:kernel> publishM2
[info] scalastyle using config /Users/allison.portis/m1/delta/kernel/scalastyle-config.xml
[info] scalastyle using config /Users/allison.portis/m1/delta/kernel/scalastyle-config.xml
[info] Wrote /Users/allison.portis/m1/delta/kernel/kernel-api/target/delta-kernel-api-0.1.0-SNAPSHOT.pom
[info] Wrote /Users/allison.portis/m1/delta/kernel/kernel-default/target/delta-kernel-default-0.1.0-SNAPSHOT.pom
[info] scalastyle Processed 0 file(s)
[info] scalastyle Processed 0 file(s)
[info] scalastyle Found 0 errors
[info] scalastyle Found 0 errors
[info] scalastyle Found 0 warnings
[info] scalastyle Found 0 warnings
[info] scalastyle Found 0 infos
[info] scalastyle Found 0 infos
[info] scalastyle Finished in 8 ms
[info] scalastyle Finished in 8 ms
[success] created output: /Users/allison.portis/m1/delta/kernel/kernel-api/target
[success] created output: /Users/allison.portis/m1/delta/kernel/kernel-default/target
[info] published delta-kernel-api to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-api/0.1.0-SNAPSHOT/delta-kernel-api-0.1.0-SNAPSHOT.pom
[info] published delta-kernel-api to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-api/0.1.0-SNAPSHOT/delta-kernel-api-0.1.0-SNAPSHOT.jar
[info] published delta-kernel-api to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-api/0.1.0-SNAPSHOT/delta-kernel-api-0.1.0-SNAPSHOT-sources.jar
[info] published delta-kernel-api to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-api/0.1.0-SNAPSHOT/delta-kernel-api-0.1.0-SNAPSHOT-javadoc.jar
[info] published delta-kernel-default to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-default/0.1.0-SNAPSHOT/delta-kernel-default-0.1.0-SNAPSHOT.pom
[info] published delta-kernel-default to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-default/0.1.0-SNAPSHOT/delta-kernel-default-0.1.0-SNAPSHOT.jar
[info] published delta-kernel-default to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-default/0.1.0-SNAPSHOT/delta-kernel-default-0.1.0-SNAPSHOT-sources.jar
[info] published delta-kernel-default to file:/Users/allison.portis/.m2/repository/io/delta/delta-kernel-default/0.1.0-SNAPSHOT/delta-kernel-default-0.1.0-SNAPSHOT-javadoc.jar
|
|
||
| import ReleaseTransformations._ | ||
|
|
||
| val scala212 = "2.12.15" |
There was a problem hiding this comment.
do we need scala here related stuff here and below?
There was a problem hiding this comment.
Seems like 2.12 is the default anyways. But not sure if it's better to be explicit?
tdas
reviewed
May 25, 2023
tdas
approved these changes
May 26, 2023
allisonport-db
force-pushed
the
addKernelStructure
branch
from
9a37a9a to
4ea53ef
Compare
allisonport-db
added a commit
that referenced
this pull request
Jun 2, 2023
Based off of #1785. Updates our current `test.yaml` to not run when there are only changes in `kernel/`. Adds a separate action for future `kernel/` tests. Currently this just compiles the code. ### Testing I merged these changes to my own fork and created these PRs to check allisonport-db#11 Changes to `core/src/main/scala/org/apache/spark/sql/delta/Snapshot.scala` - https://github.com/allisonport-db/delta/actions/runs/5125555163/jobs/9218878662?pr=11 - https://github.com/allisonport-db/delta/actions/runs/5125555163/jobs/9218878794?pr=11 allisonport-db#12 Changes to `build.sbt` - https://github.com/allisonport-db/delta/actions/runs/5125557362/jobs/9218883935?pr=12 - https://github.com/allisonport-db/delta/actions/runs/5125557362/jobs/9218884043?pr=12 allisonport-db#13 Changes to `examples/scala/src/main/scala/example/ChangeDataFeed.scala` - https://github.com/allisonport-db/delta/actions/runs/5125558258/jobs/9218886849?pr=13 - https://github.com/allisonport-db/delta/actions/runs/5125558258/jobs/9218886959?pr=13 allisonport-db#14 Changes to `run-tests.py` - https://github.com/allisonport-db/delta/actions/runs/5125560869/jobs/9218892247?pr=14 - https://github.com/allisonport-db/delta/actions/runs/5125560869/jobs/9218892419?pr=14 allisonport-db#15 Changes to `kernel/build.sbt` (Spark tests SHOULD NOT run) - https://github.com/allisonport-db/delta/actions/runs/5125973036/jobs/9219853307?pr=15 (skipped) - https://github.com/allisonport-db/delta/actions/runs/5125973036/jobs/9219853403?pr=15 (skipped) Closes #1786 Signed-off-by: Allison Portis <allison.portis@databricks.com> GitOrigin-RevId: cd5449a905c057f61f66afd7dfd5e5cb19348270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1783 for details.
This PR just sets up the
kernel/subdirectory and sbt for future development.#1786 updates the github actions and is based off of this PR