[Spark] Add Read support for RowCommitVersion and Row Tracking Preservation in Read/Write #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
force-pushed
the
stack/delta-row-commit-version
branch
from
d3c16a0
to
88fd1a9
Compare
johanl-db
approved these changes
Apr 16, 2024
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdTestUtils.scala
Show resolved
Hide resolved
Comment on lines
+84
to
+85
| RowIdMetadataStructField.isRowIdColumn(field) || | ||
| RowCommitVersion.MetadataStructField.isRowCommitVersionColumn(field) |
There was a problem hiding this comment.
Not for now but we'll probably want to unify naming later on: RowIdMetadataStructField -> RowId.MetadataStructField
There was a problem hiding this comment.
@johanl-db I already have that plan in mind for a future PR :)
longvu-db
force-pushed
the
stack/delta-row-commit-version
branch
from
88fd1a9
to
bf7f8e7
Compare
|
The failure is known on master and was fixed an hour ago after the actions on this PR were started. Merging this. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
row_commit_versionfield to the _metadata column for Delta tables, allowing us to read therow_commit_versionfrom the file metadata after it is stored.How was this patch tested?
Added UTs.
Does this PR introduce any user-facing changes?
No.