Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention deletion of delta log entries in PROTOCOL #913

Closed
wants to merge 2 commits into from
Closed

Mention deletion of delta log entries in PROTOCOL #913

wants to merge 2 commits into from

Conversation

wjones127
Copy link
Contributor

Existing writers may delete old JSON log entries if there are newer checkpoints.

Fixes #888.

@wjones127
Mention deletion of delta log entries in PROTOCOL
d7ad323 
Existing writers may delete old JSON log entries if there are newer checkpoints.
@allisonport-db allisonport-db self-assigned this Jan 26, 2022
allisonport-db
allisonport-db reviewed Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@allisonport-db allisonport-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I added some minor suggestions.

PROTOCOL.md Outdated Show resolved Hide resolved
PROTOCOL.md Outdated Show resolved Hide resolved
PROTOCOL.md Outdated Show resolved Hide resolved
@wjones127 @allisonport-db
Apply suggestions from code review
af46503 
Co-authored-by: Allison Portis <89107911+allisonport-db@users.noreply.github.com>
@wjones127 wjones127 deleted the patch-1 branch February 4, 2022 20:42
allisonport-db pushed a commit that referenced this pull request Feb 4, 2022
@wjones127 @allisonport-db
Mention deletion of delta log entries in PROTOCOL
38807a7 
Existing writers may delete old JSON log entries if there are newer checkpoints.

Fixes #888.

Closes #913

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 79cce715d78edb9aca33f2f8db7861e15634e812
@wjones127 wjones127 mentioned this pull request May 10, 2022
Closed
jbguerraz pushed a commit to jbguerraz/delta that referenced this pull request Jul 6, 2022
@wjones127 @jbguerraz
Mention deletion of delta log entries in PROTOCOL
b424268 
Existing writers may delete old JSON log entries if there are newer checkpoints.

Fixes delta-io#888.

Closes delta-io#913

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 79cce715d78edb9aca33f2f8db7861e15634e812
jbguerraz pushed a commit to jbguerraz/delta that referenced this pull request Jul 6, 2022
@wjones127 @jbguerraz
Mention deletion of delta log entries in PROTOCOL
61acf68 
Existing writers may delete old JSON log entries if there are newer checkpoints.

Fixes delta-io#888.

Closes delta-io#913

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 79cce715d78edb9aca33f2f8db7861e15634e812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsxwing zsxwing zsxwing approved these changes

@allisonport-db allisonport-db Awaiting requested review from allisonport-db

Assignees

@allisonport-db allisonport-db

Labels
waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe logRetentionDuration in PROTOCOL
3 participants
@wjones127 @zsxwing @allisonport-db