Prevent the potential for a panic in the string_to_timestamp coercions #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyler
force-pushed
the
less-panic-in-coersions
branch
from
d353ef5 to
15e7578
Compare
The original code was turning nanos into micros anyways, so we can use the more safe timestamp_micros() code. For timestamp_nanos_opt() it can return None if the dates that cannot be represented as nanoseconds between 1677-09-21T00:12:43.145224192 and 2262-04-11T23:47:16.854775807. Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
rtyler
force-pushed
the
less-panic-in-coersions
branch
from
15e7578 to
4cadc33
Compare
mightyshazam
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was turning nanos into micros anyways, so we can use the more safe timestamp_micros() code.
For timestamp_nanos_opt() it can return None if the dates that cannot be represented as nanoseconds between 1677-09-21T00:12:43.145224192 and 2262-04-11T23:47:16.854775807.