Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade]: migrate and protoc versions , build proto according to newer compilers #368

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

abesheknarayan
Copy link
Member

@abesheknarayan abesheknarayan commented Oct 21, 2021

  1. Change gemnasium/migrate to golang-migrate/migrate
  2. Upgrade protoc version from 3.02 to 3.18
  3. Modify script for building proto files accordingly
  4. Update Readme and moved setup docs to wiki
  5. Update circle-ci config files according to new modules
  6. The key which was used for testing didn't mention requested hostname field in the subject alternatives names extension (SAN) but only in Common name field. Go 1.15+ made SAN field to be mandatory, so generate new certs and keys for testing
    Links: crypto/x509: Go 1.15 will break default connections to AWS RDS golang/go#39568 (comment)
    https://letsencrypt.org/docs/certificates-for-localhost/#making-and-trusting-your-own-certificates

Copy link
Member

@siva2204 siva2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ig there are lot of unwanted pkg added to go.mod, do run go mod tidy to remove unwanted pkg.

@siva2204 siva2204 merged commit a20f3c9 into master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants