Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a fallback for unknown value "4 weeks" #1796

Closed
link2xt opened this issue Feb 8, 2021 · 9 comments
Closed

Provide a fallback for unknown value "4 weeks" #1796

link2xt opened this issue Feb 8, 2021 · 9 comments
Labels

Comments

@link2xt
Copy link
Contributor

link2xt commented Feb 8, 2021

I had "Delete messages from device" set to 4 weeks. After update #1786 it shows "Unknown".
screen

@r10s
Copy link
Member

r10s commented Feb 8, 2021

yip, we kept the "4 weeks" string, as it was a selectable option, we should use that.

what shall happen to the unknown value in the selection dialog? is it mapped to the next one? or just nothing is selected?

and, as more and other "unknown" values may happen in the future, in addition to the "4 weeks", i would write just "On" instead of "Unknown"

@r10s r10s added the bug label Feb 8, 2021
@link2xt
Copy link
Contributor Author

link2xt commented Feb 8, 2021

what shall happen to the unknown value in the selection dialog? is it mapped to the next one? or just nothing is selected?

With disappearing messages I tried to map to some other value close to the one selected. Here nothing is selected now.

@adbenitez
Copy link
Member

there could be other Delta Chat clients with custom timers, so I would rather just show "X seconds" in that case

@Hocuri
Copy link
Collaborator

Hocuri commented Apr 17, 2021

4 weeks are going to be lots of seconds, though

@adbenitez
Copy link
Member

seconds can be converted to minutes, hours (and maybe weeks), there are string templates for X seconds, and X hours that are displayed in the message bubbles

@Hocuri
Copy link
Collaborator

Hocuri commented Apr 18, 2021

Not sure if that's worth the effort, though, unknown values won't be that frequent as this is only about the deltachat-android app, which we have full control over

@adbenitez
Copy link
Member

the advantage is that it needs to be translated only once, no need to drop translations and add new ones if then we decide that it is better to change X with Y or add a new category with X months

@adbenitez
Copy link
Member

is this still an issue?

@r10s
Copy link
Member

r10s commented Apr 12, 2022

i do not think, there were changes in this area. however, i would be fine with closing the issue. lots of time have passed since we changed from 4 to 5 weeks, so most of ppl will have already dealt with the string "Unknown" and improvements are maybe a bit too late and not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants