-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a fallback for unknown value "4 weeks" #1796
Comments
yip, we kept the "4 weeks" string, as it was a selectable option, we should use that. what shall happen to the unknown value in the selection dialog? is it mapped to the next one? or just nothing is selected? and, as more and other "unknown" values may happen in the future, in addition to the "4 weeks", i would write just "On" instead of "Unknown" |
With disappearing messages I tried to map to some other value close to the one selected. Here nothing is selected now. |
there could be other Delta Chat clients with custom timers, so I would rather just show "X seconds" in that case |
4 weeks are going to be lots of seconds, though |
seconds can be converted to minutes, hours (and maybe weeks), there are string templates for X seconds, and X hours that are displayed in the message bubbles |
Not sure if that's worth the effort, though, unknown values won't be that frequent as this is only about the deltachat-android app, which we have full control over |
the advantage is that it needs to be translated only once, no need to drop translations and add new ones if then we decide that it is better to change X with Y or add a new category with X months |
is this still an issue? |
i do not think, there were changes in this area. however, i would be fine with closing the issue. lots of time have passed since we changed from 4 to 5 weeks, so most of ppl will have already dealt with the string "Unknown" and improvements are maybe a bit too late and not worth the effort. |
I had "Delete messages from device" set to 4 weeks. After update #1786 it shows "Unknown".
The text was updated successfully, but these errors were encountered: