Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 4 weeks option with 5 weeks option #1786

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Replace 4 weeks option with 5 weeks option #1786

merged 1 commit into from
Feb 3, 2021

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Feb 2, 2021

While 4 weeks always fits in a month,
5 weeks (35 days) always covers at least a month,
so it can be used in a situation where messages are required to
be stored for a month.

While 4 weeks always fits in a month,
5 weeks (35 days) always covers at least a month,
so it can be used in a situation where messages are required to
be stored for a month.
@link2xt
Copy link
Contributor Author

link2xt commented Feb 2, 2021

This was requested on the forum: https://support.delta.chat/t/ephemeral-messages/1415

Since deltachat/deltachat-core-rust#2183 is merged, this does not require any core changes.

Related recent PR: #1780

@link2xt link2xt merged commit 9e610e5 into master Feb 3, 2021
@link2xt link2xt deleted the 5weeks branch February 3, 2021 10:34
@r10s
Copy link
Member

r10s commented Feb 3, 2021

i pushed the new string to transifex :)

EDIT: i will keep the 4-week string for now, until all os have changed, otherwise this will cause troubles in the meanwhile ... re-added that directly on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants