Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list of ephemeral message options #1780

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jan 30, 2021

Also match unknown options to some known option, not "disabled".

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the outcome of user tests with @kermoshina, right?

it should work, it is a bit hard to check the values, i needed some comments to really review that, if you like, you can merge them in, see #1782

an idea might be to put the values as seconds to array.xml (as done for mute and the other autodel-stuff), that would at least make the java-part more readable (for the closes-value one could use a loop then). however, maybe for the next time, otoh these values are not changed that often and now it seems right :)

core probably also needs more strings for the system messages? maybe also add them in this pr, so that the things, once merged, can be translated together then.

Also match unknown options to some known option, not "disabled".
@link2xt
Copy link
Contributor Author

link2xt commented Jan 30, 2021

Related core PR: deltachat/deltachat-core-rust#2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants