add strings needed for instant onboarding #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
r10s
force-pushed
the
instant-onboarding-strings
branch
from
ac26898
to
583200d
Compare
|
Thank you for this @r10s, I've adjusted the strings now in the PR, they should reflect this current state |
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
|
ftr, the strings are discussed with at least @adzialocha and @hpk42 |
adbenitez
approved these changes
Apr 29, 2024
adzialocha
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR extracts new strings from deltachat/deltachat-desktop#3773.
the following strings were not added as they are existing already in a sufficient way (desktop PR needs to be changed):
onboarding_title->welcome_desktop(exclamation mark can be added later)onboarding_subtitle->welcome_chat_over_email(dot can be removed later)onboarding_scan_qr_code->qrscan_titlemultidevice_setup_option->multidevice_receiver_titleimport_backup_option->import_backup_title(iirc, it was renamed to "restore" on purpose, let's stay with that for now)instant_onboarding_confirm_label->ok(this is used in a message box, right? i would stay calm there, otherwise use the other "Let's Get Started")for the other strings, i stayed with existing keys - they're good enough and i did not want to add additional noise.
for upper/lower case: we voted for capitalising titles and buttons at some point and do not want to change this currently; i adapted the strings accordingly.
@adzialocha will add some screenshots to deltachat/deltachat-desktop#3773 so one can get a better idea
closes #2995