hide IMAP folder options on chatmail #3050
Conversation
|
To test the changes in this pull request, install this apk: |
XCHATMAIL capability was not deployed, it is fixed now. |
|
great! works perfectly fine |
|
probably "prefer encryption" toggle should be locked/disabled in ON mode, to avoid people accidentally disabling encryption in chatmail servers more importantly, the "import contacts from address book" should also be hidden |
|
|
||
| if (dcContext.isChatmail()) { | ||
| sentboxWatchCheckbox.setVisible(false); | ||
| bccSelfCheckbox.setVisible(false); |
There was a problem hiding this comment.
if someone that is already using chatmail disabled this toggle, now they will not be able to enable it anymore, would be nice to do some migration checking for this property and maybe also the other ones, and set/force the correct default values
There was a problem hiding this comment.
imu, whatever is chosen for these four options, it does not make a difference for chatmail. but not sure - otherwise, i would prefer some migration in the core, or that the settings are ignored, at least when they're harmful, i think, we do want to have less footguns and more defaults for chatmail :) cc @link2xt
There was a problem hiding this comment.
bcc self makes a difference without it multidevice sync is broken, or do you mean that internally core already ignores their value if chatmail flag is set?
There was a problem hiding this comment.
I think it is fine to hide the settings. Core sets mvbox_move on configuration, we can also change other settings on configuration. If users encounter problems, they can report bug and look into context info to see the settings, if they happen to be broken then reconfiguring will help.
There was a problem hiding this comment.
deltachat/deltachat-core-rust#5568
I don't want to reset settings in a migration or anything similar because immediately after migration we don't know if it is a chatmail until we connect to IMAP. And resetting every time when we connect to IMAP will break tests that test these settings by manually setting them on nine.testrun.org accounts.
|
"prefer e2ee" and "read system address book" are hidden now as well, thanks for the pointer! if the latter was set before, it is now ignored on chatmail - the other options are reset by deltachat/deltachat-core-rust#5568 - so, i think, this is good enough - i do not expect many ppl playing around with these options anyways |
|
To test the changes in this pull request, install this apk: |
this PR makes use of the
is_chatmailconfig introduced by deltachat/deltachat-core-rust#5567 and hides the IMAP folder options.for whatever reason,EDIT: works now, see belowis_chatmailis currently always0(also in "View Log" which is generated by core directly), might be things are not rolled out yet.this is what it will look like:
left: chatmail=0, right: chatmail=1
targets deltachat/deltachat-core-rust#5380
when this PR gets merged, we need to file issues/PR for the same change on desktop/ios