Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate webxdc sendUpdate's desc parameter #6245

Closed
adbenitez opened this issue Nov 21, 2024 · 2 comments · Fixed by #6255
Closed

Deprecate webxdc sendUpdate's desc parameter #6245

adbenitez opened this issue Nov 21, 2024 · 2 comments · Fixed by #6255
Assignees
Labels

Comments

@adbenitez
Copy link
Member

adbenitez commented Nov 21, 2024

as commented in #6230 (comment)

the desc field is unnecessary, was never needed/used by other implementators that raised questions about it, ex. in XMPP, it was a DeltaChat-specific thing mainly, to show something nice to a classic email user, but that doesn't make much sense anyways as status updates can be a lot and are internal data not supposed to be analyzed or described manually

  • so we should keep it but deprecate it, don't use it internally
  • the webxdc specs need to be updated
  • the UIs need to update their webxdc.js file to not fail if the desc argument is not given

this is a backwards compatible change since in javascript you can call functions with arbitrary amount of extra arguments and they will just be ignored/unused

@Septias Septias self-assigned this Nov 22, 2024
@hpk42
Copy link
Contributor

hpk42 commented Nov 24, 2024 via email

@r10s
Copy link
Member

r10s commented Nov 24, 2024

@Septias i already did a little PR, i overlooked you were assigned

r10s added a commit that referenced this issue Nov 24, 2024
this PR removes most usages of the `descr` parameter.

- to avoid noise in different branches etc. (as annoying on similar, at
a first glance simple changes), i left the external API stable

- also, the effort to do a database migration seems to be over the top,
so the column is left and set to empty strings on future updates - maybe
we can recycle the column at some point ;)

closes #6245
adbenitez added a commit to deltachat/deltachat-android that referenced this issue Nov 24, 2024
the 'description' parameter is about to be deprecated,
see deltachat/deltachat-core-rust#6245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants