Integrate dc-node into this repository

[missytake]

Hopefully this makes some things easier.

• Migrate GitHub actions
• GitHub action to publish release to npm on git tag
• Document changed release flow
• Pull changes from Upgrade to deltachat-core version 1.78.0 fix standalone context events deltachat-node#552 as soon as it's merged
• Migrate issues to this repository?
• update nodejs source-link in core readme

After this is merged, we still need to:

• create a tag before the old repository is archived

#skip-changelog

[hpk42]

for now let's see this as experimental and "trying out" things. It's not certain it makes sense in the end but it's good to know if it's relatively easy or rather involved to make it work.

[missytake]

I would say it's relatively easy, as in "pretty much done". It works so far and all the CI is successfully migrated. The npm release flow is still a bit unclear to me, but apart from that I mostly consider it done. Just need to throw away some garbage (like the license :P and some git files) and then we could just pull, merge it, and archive the old repository.

[Simon-Laux]

what about the node release on tag? do you want to auto upload it to npm (npm publish, probably needs somekind of login ENV or token)

[missytake]

actually, let's keep the license. The python subdirectory also has its own license, I think it's necessary for the published build.

[missytake]

what about the node release on tag? do you want to auto upload it to npm (npm publish, probably needs somekind of login ENV or token)

yeah, let's do this. There is this github action we can use: https://github.com/marketplace/actions/npm-publish

I don't have an npm account, can you just add an access token to the github secrets? (do we want to give release rights to the CI / everyone in the deltachat github organization??)

[missytake]

https://github.com/deltachat/deltachat-core-rust/runs/6305997093?check_suite_focus=true confirms that the npm run test failure on windows is only about CLRF vs LF.

I excluded the lint checks from the Windows CI for now. The lint checks are run only on ubuntu & macOS now, that should still suffice. The normal tests are of course run on Windows, too. (developers who work with Windows can still do npm run lint-fix if the code doesn't look pretty on their machines.)

[missytake]

Hm, the github actions work now, but a npm i https://download.delta.chat/node/preview/deltachat-node-3283.tar.gz still throws an error - any ideas which path is wrong?

npm WARN deprecated @types/error-stack-parser@2.0.0: This is a stub types definition for error-stack-parser (https://github.com/stacktracejs/error-stack-parser). error-stack-parser provides its own type definitions, so you don't need @types/error-stack-parser installed!
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated uuid@3.3.3: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated core-js@2.6.12: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 1
npm ERR! path /home/user/git/deltachat-desktop/node_modules/deltachat-node
npm ERR! command failed
npm ERR! command sh -c node node/scripts/install.js
npm ERR! node:internal/modules/cjs/loader:936
npm ERR!   throw err;
npm ERR!   ^
npm ERR! 
npm ERR! Error: Cannot find module '/home/user/git/deltachat-desktop/node_modules/deltachat-node/node/scripts/install.js'
npm ERR!     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:778:27)
npm ERR!     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
npm ERR!     at node:internal/main/run_main_module:17:47 {
npm ERR!   code: 'MODULE_NOT_FOUND',
npm ERR!   requireStack: []
npm ERR! }

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/user/.npm/_logs/2022-05-09T10_06_58_391Z-debug.log

[missytake]

It seems like node/scripts is not packaged into the tar.gz o.0 but it isn't in .npmignore...

[missytake]

Ah, https://docs.npmjs.com/cli/v8/configuring-npm/package-json/#files solves this.