Build armv7 deltachat-rpc-server binaries without NDK #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbenitez
reviewed
Mar 13, 2023
link2xt
force-pushed
the
link2xt/zig-build-arm-32
branch
4 times, most recently
from
7bc8f69
to
b70b181
Compare
adbenitez
reviewed
Mar 13, 2023
| - name: Upload armv7 binary | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: armv7-unknown-linux-musleabihf |
There was a problem hiding this comment.
what is the difference between this and the android armv7 binary? do we need both of them?
There was a problem hiding this comment.
This is built using Zig toolchain, and Android binary is built using NDK.
Zig uses recent version of Clang/LLVM and provides its own compiler runtime library rather than using clang one.
Android NDK that we use has an old Clang 12 IIRC and uses official LLVM compiler-rt.
Zig builds are statically linked against musl libc, Android builds are using bionic libc.
I would like to get rid of Android NDK builds, but for now let's keep them as a backup. Normally you do not need them.
adbenitez
approved these changes
Mar 13, 2023
link2xt
force-pushed
the
link2xt/zig-build-arm-32
branch
from
b70b181
to
73e7ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails on 0.10.1, but works after upgrading zig to the dev build.