-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Webxdc realtime by default #6125
Conversation
+1 it is better to use a well know term and then explain "Delta Chat mini-apps are better/more-secure than X" than using a new term |
If we do deltachat/deltachat-android#3398 (review) we don't need this PR, right? Asking the user once seems better than just enabling it now without any warning. |
still it is good if it is on by default for new users, and if you ask in a dialog it is not clear how to disable it, as it currently is, user first learns where the setting is and disables it, then get the chance to enable it again, but they know where it is already and can go back to disable it |
At least here we said that it is disabled by default etc., just enabling it without any warning is not nice: https://support.delta.chat/t/can-realtime-chat-be-disabled/3160 |
maybe we can keep it disabled for existing users and enable it only for new? |
anyways it was disabled because it was experimental, it is normal that now it is enabled by default if it is out of experimental |
At least this, just enabling it for existing users especially since it bypasses all proxy settings will definitely make some users unhappy when they discover it. |
that would be good since with the dialog (at least on android) we would catch the situation for users that actually want to use the feature but have the option disabled because they are old users |
@Hocuri i added a little PR to update the documentation for the changed default. the PR has constantly failing python and/or jsonprc test, that seems to be real - i am not fluent with that part of the code and would prefer if someone else can have a look :) |
realtime is currently failing with c2.testrun.org because of deltachat/chatmail#445 |
In order not to delay the release, I'm going to merge this; the release will take some time until it hits the stores, so we can still change things until then. Another idea to maybe get everyone happy: What about disabling it for all existing users that are using a proxy/socks5? |
ftr, proxy-options as they're used and very useful today are not officially released (beside ArcaneChat) -- before, proxy was declared as experimental and also much more limited |
SOCKS5 setting was released for a long time and migrated to new proxy settings. Using SOCKS5 is described here: https://lefherz.net/2022/08/28/how-to-setup-delta-chat-on-tails-in-4-steps/ |
true. still, it was declared as experimental all the time since then (beside $reasons, also because of the issue with the proxy not being used during configure) -- only saying that we should take that into account when considering doing special things about it |
Mainly after discussions between @hpk42, @r10s, and @adbenitez.
Todo for the UIs:
Considerations:
Open questions:
Future possibilities: