refactor: eliminating indexing_slicing #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
changed the title
is_file_in_use
There is a change in behavior for the case when name is the same as the suffix (`name_len` == `namespc_len`), but normally `files_in_use` should not contain empty filenames.
link2xt
force-pushed
the
link2xt/is_file_in_use-no-slicing
branch
3 times, most recently
from
8b8e175 to
37c2348
Compare
link2xt
force-pushed
the
link2xt/is_file_in_use-no-slicing
branch
8 times, most recently
from
1d0b3c0 to
52e0526
Compare
clippy::indexing_slicing is already allowed in test builds.
link2xt
force-pushed
the
link2xt/is_file_in_use-no-slicing
branch
from
52e0526 to
a264cbf
Compare
|
When I remove this: deltachat-core-rust/src/securejoin.rs Line 282 in 399716a Clippy still does not catch this slicing: deltachat-core-rust/src/securejoin.rs Line 351 in 399716a This should be reduced to a minimal case and reported to https://github.com/rust-lang/rust-clippy EDIT: reported here: rust-lang/rust-clippy#13703 EDIT2: this is handled by |
link2xt
force-pushed
the
link2xt/is_file_in_use-no-slicing
branch
from
5765b0c to
0cdd9b4
Compare
|
Only |
It is impossible to allow this in the new code now.
link2xt
force-pushed
the
link2xt/is_file_in_use-no-slicing
branch
from
76d5f95 to
c5c5e14
Compare
link2xt
changed the title
Simon-Laux
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all indexing_slicing from the core, so next time we get something like #6221 we can immediately blame dependencies. See commit messages for details.
clippy::string_slice is a separate issue #6224